tests: Add tests for some components #11910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Artifacts
|
EshaanAgg
changed the title
AlexVelezLl
reviewed
Feb 28, 2024
AlexVelezLl
reviewed
Feb 28, 2024
| test('renders correctly with label placeholder and options', async () => { | ||
| renderComponent(); | ||
|
|
||
| expect(screen.getByText('Gender')).toBeInTheDocument(); |
There was a problem hiding this comment.
I think we could use getByLabel, to diferentiate that this is the label of the input. And we can add an array of options that it should contain.
Also, the component is responsible for emitting events when a selected value changes, which could be another test case.
There was a problem hiding this comment.
Using getByLabelText does not work for this particular component. I suspect it's due to the markup that's surrounding it.
<div class="ui-select-label-text is-inline">
Gender
</div>
AlexVelezLl
reviewed
Mar 1, 2024
There was a problem hiding this comment.
Thanks @EshaanAgg. Code looks good to me :) will let the final approve to @MisRob.
|
Ah I'm sorry, I assigned myself in hopes I would use this opportunity to learn more but I don't think I will get to it this week. Thanks for review @AlexVelezLl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TotalPointsGenderDisplayTextGenderSelectI am not testing the user interaction in the case of the
GenderSelectcomponent, as we are using a pre-defined component from the Kolibri library, and thus, it should be the duty of theKDSpackage to test the UI interactions and then export the components.Testing checklist
PR process
Reviewer checklist
yarnandpip)