Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit-ci-lite action to automate PR lint fixes #12034

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

thesujai
Copy link
Contributor

@thesujai thesujai commented Mar 28, 2024

Summary

Just add a pre-commit-ci-lite action at the end of pre-commit.yml workflow which will automate lint fixes in PRs
Check this out thesujai#9
Perhaps, makes life of a dev a little less harder, or maybe more ?

References

Fixes #10876

Reviewer guidance

For this to work pre-commit.ci lite must be installed in this repo as a gh action add on
refer: https://github.com/pre-commit-ci/lite-action?tab=readme-ov-file#setup


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment SIZE: very small labels Mar 28, 2024
@rtibbles rtibbles self-assigned this Mar 29, 2024
@rtibbles
Copy link
Member

My only concern here is that this will work for PRs from the learningequality repo, but will not work for PRs from other forks. That said, I don't think we have any way to know whether it will work unless we try!

@rtibbles rtibbles merged commit bac2ab5 into learningequality:develop Mar 29, 2024
31 checks passed
@thesujai
Copy link
Contributor Author

@rtibbles May I create a sample PR to try?

@rtibbles
Copy link
Member

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: dev-ops Continuous integration & deployment SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow automatic triggering of autofixing of Pull Request linting errors with a comment
2 participants