Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove any order_by to ensure values_list is properly unique. #12044

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 2, 2024

Summary

  • Prevents duplicate instance_ids when getting preferred instance ids for metadata import

Reviewer guidance

Do a full facility import from a facility with a lot of quizzes and lessons - see that it doesn't do a lot of unnecessary calls to clients during metadata import


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the Kolibri 0.16: Planned Patch 1 milestone Apr 2, 2024
@rtibbles rtibbles requested a review from bjester April 2, 2024 17:30
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: very small labels Apr 2, 2024
@rtibbles rtibbles merged commit 4f7ed2b into learningequality:release-v0.16.x Apr 2, 2024
34 checks passed
@rtibbles rtibbles deleted the no_duplicate_instance_ids branch April 2, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants