Use router.replace for redirect. #12067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Uses router.replace instead of redirect
References
Follow up to #12039 to avoid unnecessary page loads
Reviewer guidance
Ensure your device is setup to allow anonymous resource browsing.
Go to a resource in a lesson as a logged in user.
Copy the URL.
Logout.
Go to the URL you copied.
See that it redirects without a page reload, and without the pasted URL appearing in the browser history.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)