Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use router.replace for redirect. #12067

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Apr 9, 2024

Summary

Uses router.replace instead of redirect

References

Follow up to #12039 to avoid unnecessary page loads

Reviewer guidance

Ensure your device is setup to allow anonymous resource browsing.
Go to a resource in a lesson as a logged in user.
Copy the URL.
Logout.
Go to the URL you copied.
See that it redirects without a page reload, and without the pasted URL appearing in the browser history.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from marcellamaki April 9, 2024 17:30
@rtibbles rtibbles added the TODO: needs review Waiting for review label Apr 9, 2024
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Apr 9, 2024
@marcellamaki
Copy link
Member

This does load the pasted link without a hard page reload, but it is appearing in my browser history (back button, and also my "history" in the Chrome menu). I don't think I follow why it shouldn't appear?

@marcellamaki marcellamaki self-assigned this Apr 23, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some clarifying details about the URL over slack, confirming this works as expected

@marcellamaki marcellamaki merged commit 71f2f64 into learningequality:develop Apr 24, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants