Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coach loading state reports #12178

Conversation

marcellamaki
Copy link
Member

@marcellamaki marcellamaki commented May 15, 2024

Summary

Makes some small improvements to loading state management. (There may be other places where we see similar scenarios that are just not found yet due to lingering coach tech debt in loading state).

References

Fixes #12126
Fixes #11856
(hopefully)

Reviewer guidance

Linked PRs have more relevant screengrabs/guidance to better understand the scenarios

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels May 15, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes check out.

@marcellamaki marcellamaki merged commit b3cb256 into learningequality:release-v0.16.x May 15, 2024
34 checks passed
@pcenov
Copy link
Member

pcenov commented May 16, 2024

Looks and feels much better, was able to identify just a couple of issues and filed a follow-up issue here: #12180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants