Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate the syncqueue table before we add the unique constraint. #12197

Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Adds truncation of the syncqueue table to the migration before we add a constraint

References

Fixes #12194

Reviewer guidance

Have I got my SQL right? I only checked the dialect of the default connection, even though technically for SQLite there are multiple databases, but we don't mix and match database types in Kolibri.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from bjester May 22, 2024 23:10
@rtibbles rtibbles added the TODO: needs review Waiting for review label May 22, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... and removed TODO: needs review Waiting for review labels May 22, 2024
@rtibbles rtibbles force-pushed the truncate_syncqueue branch 2 times, most recently from 85041cd to 78ab704 Compare May 22, 2024 23:16
@rtibbles rtibbles force-pushed the truncate_syncqueue branch from 78ab704 to 091dda1 Compare May 22, 2024 23:22
@rtibbles rtibbles force-pushed the truncate_syncqueue branch from 091dda1 to 8562347 Compare May 22, 2024 23:28
@rtibbles rtibbles marked this pull request as ready for review May 22, 2024 23:30
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtibbles rtibbles merged commit 4abdca3 into learningequality:release-v0.16.x May 23, 2024
34 checks passed
@rtibbles rtibbles deleted the truncate_syncqueue branch May 23, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants