Revert change that prevented search redirect in all cases.

[rtibbles]

Summary

• Added another condition for TOPICS_TOPIC_SEARCH redirection #12019 introduced a regression that caused the search redirect never to occur for folders with only leaf nodes as children
• Reverts most of the changes in that PR to restore former behaviour
• Retains the setting of sidePanelOpen to false, but just sets this whenever topic navigation occurs

References

Bug introduced:

Reviewer guidance

Navigate to a folder with only leaf nodes as children on desktop.
Confirm that the search side nav properly displays.
Switch to mobile browsing in dev tools.
Navigate down the topic hierarchy using the folders sidepanel.
Ensure that each time you navigate, the side panel is properly hidden once you have navigated to the next folder.

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-.pex
Windows Installer (EXE)	kolibri-0.16.2b2.dev0+git.1191.gc60c29f8-windows-setup-unsigned.exe
Debian Package	kolibri_0.16.2b2.dev0+git.1191.gc60c29f8-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.2b2.dev0+git.1191.gc60c29f8-0.4.2.dmg
Android Package (APK)	kolibri-0.16.2b2.dev0+git.1191.gc60c29f8-0.1.3-debug.apk
TAR file	kolibri-0.16.2b2.dev0+git.1191.gc60c29f8.tar.gz
WHL file	kolibri-0.16.2b2.dev0+git.1191.gc60c29f8-py2.py3-none-any.whl

[marcellamaki]

Reverted code changes look correct here, as well as the setting sidePanelIsOpen to false.

will wait for Peter's confirmation though :)

[pcenov]

LGTM as well!