-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move NotEnoughResourcesModal to CreateQuizSection #12249
Move NotEnoughResourcesModal to CreateQuizSection #12249
Conversation
Build Artifacts
|
@pcenov @radinamatic this can be reviewed by the QA team as well! thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to make. Thanks @LianaHarris360!
Leaving final approval to Jacob, just in case I missed something!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passes, good to go! 👍🏽 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! Thanks @LianaHarris360
Summary
This pull request moves the
NotEnoughResourcesModal
component intoCreateQuizSection
to avoid displaying the replacements side panel in the background whenNotEnoughResourcesModal
is shown. Navigation to the replacements side panel will occur only if there are enough replacement questions.Before:

After:
NotEnoughResourcesModalAfter.mp4
References
Closes #12229
Reviewer guidance
NotEnoughResourcesModal
should appear without the replacements side panel in the background.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)