Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NotEnoughResourcesModal to CreateQuizSection #12249

Conversation

LianaHarris360
Copy link
Member

@LianaHarris360 LianaHarris360 commented Jun 5, 2024

Summary

This pull request moves the NotEnoughResourcesModal component into CreateQuizSection to avoid displaying the replacements side panel in the background when NotEnoughResourcesModal is shown. Navigation to the replacements side panel will occur only if there are enough replacement questions.

Before:
NotEnoughResourcesModalBefore

After:

NotEnoughResourcesModalAfter.mp4

References

Closes #12229

Reviewer guidance

  1. Download resources and create a new quiz.
  2. Select options and add resources to the quiz.
  3. Select all questions and press the replace icon button.
  4. If there are not enough replacement questions, the NotEnoughResourcesModal should appear without the replacements side panel in the background.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Jun 5, 2024
@marcellamaki
Copy link
Member

@pcenov @radinamatic this can be reviewed by the QA team as well! thank you!

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to make. Thanks @LianaHarris360!

Leaving final approval to Jacob, just in case I missed something!

@radinamatic
Copy link
Member

Side panel is no more! 💥

no-more-sidebar

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 👍🏽 💯 :shipit:

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Thanks @LianaHarris360

@nucleogenesis nucleogenesis merged commit 524e0cb into learningequality:develop Jun 6, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EQM: Move "NotEnoughResourcesModal" to "CreateQuizSection"
5 participants