Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LOD description in FullOrLearnOnlyDeviceForm component #12285

Merged

Conversation

LianaHarris360
Copy link
Member

@LianaHarris360 LianaHarris360 commented Jun 14, 2024

Summary

This pull request modifies the description for Learn Only Devices in FullOrLearnOnlyDeviceForm.vue in order to eliminate the implication that an existing learn account is necessary.

Original phrase:
“This device will have one or more learner accounts imported from a full device that already exists. Learner accounts will auto-sync with the full device.”

Updated wording:
“This device will only have the features used by learners, and it will auto-sync with the full device.”

Before:

LODBefore

After:
LODAfter

References

Closes #11461

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: very small labels Jun 14, 2024
@rtibbles rtibbles requested a review from radinamatic June 14, 2024 22:15
@rtibbles
Copy link
Member

@radinamatic added you as a reviewer here as a double check on the copy update.

@radinamatic
Copy link
Member

radinamatic commented Jun 16, 2024

The phrasing is a bit over-engineered... 😅

Maybe: This device will only have the features used by learners, and it will auto-sync with the full device.

cc @carinediaz and @marcellamaki to discuss during the upcoming UX writing review.

@LianaHarris360
Copy link
Member Author

@radinamatic Is this string okay to be left as This device will auto-sync its learner accounts with an existing full device and only include Kolibri features for learners, excluding those for coaches or admins. or should it be changed to This device will only have the features used by learners, and it will auto-sync with the full device. ?

@radinamatic
Copy link
Member

Yes, please change to: This device will only have the features used by learners, and it will auto-sync with the full device.

We discussed and confirmed it yesterday during the UX writing review. Thank you @LianaHarris360 🙏🏽

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good to go! 💯 👍🏽 :shipit:

@LianaHarris360 LianaHarris360 merged commit 8b9738e into learningequality:develop Jun 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update phrasing explaining LOD option in onboarding flow
4 participants