-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update LOD description in FullOrLearnOnlyDeviceForm component #12285
Update LOD description in FullOrLearnOnlyDeviceForm component #12285
Conversation
Build Artifacts
|
@radinamatic added you as a reviewer here as a double check on the copy update. |
The phrasing is a bit over-engineered... 😅 Maybe: cc @carinediaz and @marcellamaki to discuss during the upcoming UX writing review. |
@radinamatic Is this string okay to be left as |
Yes, please change to: We discussed and confirmed it yesterday during the UX writing review. Thank you @LianaHarris360 🙏🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good to go! 💯 👍🏽
Summary
This pull request modifies the description for Learn Only Devices in
FullOrLearnOnlyDeviceForm.vue
in order to eliminate the implication that an existing learn account is necessary.Original phrase:
“This device will have one or more learner accounts imported from a full device that already exists. Learner accounts will auto-sync with the full device.”
Updated wording:
“This device will only have the features used by learners, and it will auto-sync with the full device.”
Before:
After:
References
Closes #11461
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)