Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow quiz level learners see fixed order to be edited after a quiz is opened. #12307

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • The API previously disallowed editing the quiz level learner_sees_fixed_order attribute for section randomization - but as it has no effect on the recording of data and the review of the answers for the coach, this is safe.
  • The UI also allowed this, which resulted in unexpected 400s.
  • This PR updates the API to allow this so the UI and the API are in step.

References

Fixes #12289

Reviewer guidance

Create a quiz.
Start the quiz.
Edit the quiz.
Update the Section Order property.
Save - see that it saves without errors, and that when returning to the edit page after refreshing, it is properly updated to the new value.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jun 18, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small and removed TODO: needs review Waiting for review labels Jun 18, 2024
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave the code a look and things LGTM - are you planning to add anything here? If not then should be good to go when QA gets a look at it.

@rtibbles
Copy link
Member Author

No, this is complete, just needs QA.

@radinamatic radinamatic requested a review from pcenov June 19, 2024 17:09
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtibbles rtibbles merged commit 8e46ec2 into learningequality:develop Jun 20, 2024
31 checks passed
@rtibbles rtibbles deleted the so_random branch June 20, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot edit the section order of a started quiz
3 participants