Tweaks to CLI and message extraction utility function #12320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
help
inside CLI commands to prevent trying to redefine an existing command (needed since the upgrade to commander v12).References
Fixes issues seen by @marcellamaki while trying to do a string audit.
Reviewer guidance
Run
yarn exec kolibri-tools <name of command>
for several of the i18n commands in cli.js to confirm it properly shows the help messages.Run
yarn exec kolibri-tools i18n-audit -- --output-file audit.csv --ditto-file <path to ditto export csv> --pluginFile ./build_tools/build_plugins.txt
with a file in one of the pluginsrc
directories that has invalid syntax in it, and confirm it does not error.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)