Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coreStrings import in AttemptLogList #12429

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Fix coreStrings import in AttemptLogList #12429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72297db
Fix coreStrings import in AttemptLogList
AlexVelezLl Jul 9, 2024
9029ae8
Fix handle question change
AlexVelezLl Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions kolibri/core/assets/src/views/AttemptLogList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,11 @@
enhancedQuizManagementStrings,
} from 'kolibri-common/strings/enhancedQuizManagementStrings';
import useAccordion from 'kolibri-common/components/useAccordion';
import coreStrings from 'kolibri.utils.coreStrings';
import AccordionItem from 'kolibri-common/components/AccordionItem';
import AccordionContainer from 'kolibri-common/components/AccordionContainer';
import { computed, onMounted, watch } from 'kolibri.lib.vueCompositionApi';
import { toRefs } from '@vueuse/core';
import { coreStrings } from '../mixins/commonCoreStrings';
import AttemptLogItem from './AttemptLogItem';

export default {
Expand Down Expand Up @@ -212,8 +212,8 @@
];
});

function handleQuestionChange(item) {
emit('select', item.value + currentSection.value.startQuestionNumber);
function handleQuestionChange(index) {
emit('select', index + currentSection.value.startQuestionNumber);
expandCurrentSectionIfNeeded();
}

Expand Down