Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds loose pinning of dev docs requirements to ensure correct builds … #12466

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jul 17, 2024

  • add required extension sphinxcontrib.jquery

Summary

Tested locally and it fixes the issue 👍

References

Fixes #12029

Reviewer guidance

LMK if there is a build context I'm unaware of. I've assumed that this should build on Read the Docs and for a local developer.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

…+ add required extension sphinxcontrib.jquery
@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Jul 17, 2024
@benjaoming
Copy link
Contributor Author

RTD build looks good ✔️

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the readthedocs PR build has functional search, thanks @benjaoming!

@rtibbles rtibbles merged commit 542d558 into learningequality:develop Jul 18, 2024
33 checks passed
@benjaoming benjaoming deleted the docs-minimal-pinning branch July 18, 2024 08:37
@MisRob
Copy link
Member

MisRob commented Jul 18, 2024

Hi @benjaoming! Thanks :) Lovely to see you around. Hoping all is well.

@benjaoming
Copy link
Contributor Author

Nice to e-meet you again, too @MisRob! All is good! I miss the times of wrestling Kolibri complexities! Take care and looking forward to trying the next version (is that a new logo? oy oy oy 🥹 )

@jredrejo jredrejo mentioned this pull request Oct 8, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite Loading on search in Kolibri Documentation Search
3 participants