Ensure linting errors trigger a non-zero exit code. #12572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Artifacts
|
Comment on lines
-389
to
-391
| .then(formatted => { | ||
| return formatted.code; | ||
| }) |
There was a problem hiding this comment.
Why was this then block causing the issue?
There was a problem hiding this comment.
Because it was taking the resolved value of the promise which is no longer an object with a code attribute, but now just the code itself, and then trying to read a property from it.
nucleogenesis
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes error from #9698 where the CLI calling the linting function was not properly reading the return code, so was always returning a falsy value even when there were linting errors, meaning that the exit code was always 0.
References
Root cause of the missed linting here: #12428
Reviewer guidance
Deliberately introduce a linting error.
Run
yarn run lint-frontend.Ensure that the exit code is 1.
Testing checklist
PR process
Reviewer checklist
yarnandpip)