Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fulfulde translations #12738

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

radinamatic
Copy link
Member

@radinamatic radinamatic commented Oct 23, 2024

Summary

Pulled the latest translations from Crowdin to integrate the strings that are now translated into Fulfulde.

1 2 3
2024-10-23_05-07-39 2024-10-23_05-08-48 2024-10-23_05-09-43

Not sure why 4 new strings in the setup wizard seem now updated in all languages...? 🤔

References

Reviewer guidance

Switch the locale to Fulfulde and test the coach quiz creation UI.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@radinamatic radinamatic added TODO: needs review Waiting for review P0 - critical Priority: Release blocker or regression TAG: user strings Application text that gets translated DEV: frontend labels Oct 23, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns here - and looks like we've added in some needed translations in the setup wizard.

@rtibbles rtibbles merged commit f7bdd14 into learningequality:release-v0.17.x Oct 23, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression TAG: user strings Application text that gets translated TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants