Final token updates #12754
Merged
Final token updates #12754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Device
Build Artifacts
|
rtibbles
approved these changes
Oct 25, 2024
| // palette.red.v_300 but at the same time, | ||
| // palette.red.v_300 is the darkest available red | ||
| // palette.red.v_600 but at the same time, | ||
| // palette.red.v_600 is the darkest available red | ||
| // in the palette. Using this hardcoded color was | ||
| // agreed with designers. | ||
| ':hover': { 'background-color': '#A81700' }, |
There was a problem hiding this comment.
Let's do a follow up issue to look for hard coded colours like this, and instead use the darken utilities in develop?
| @@ -115,7 +115,7 @@ | |||
| }, | |||
| linkStyle() { | |||
| const hoverBg = this.isFullscreen | |||
| ? this.$themeBrand.secondary.v_300 | |||
| ? this.$themeBrand.secondary.v_600 | |||
There was a problem hiding this comment.
Follow up from: #12742 (comment)
| @@ -63,7 +63,7 @@ | |||
| return { | |||
| color: this.$themeTokens.text, | |||
| ':hover': { | |||
| 'background-color': this.$themeBrand.secondary.v_300, | |||
| 'background-color': this.$themeBrand.secondary.v_600, | |||
There was a problem hiding this comment.
Follow up from: #12742 (comment)
| @@ -69,7 +69,7 @@ | |||
| iconStyle() { | |||
| if (this.hasSuperAdminPermission) { | |||
| return { | |||
| fill: this.lightIcon ? this.$themePalette.yellow.v_400 : this.$themeTokens.superAdmin, | |||
| fill: this.lightIcon ? this.$themePalette.yellow.v_200 : this.$themeTokens.superAdmin, | |||
| @@ -9,7 +9,7 @@ | |||
| </div> | |||
| <div | |||
| class="progress-bar-wrapper" | |||
| :style="{ backgroundColor: $themePalette.grey.v_200 }" | |||
| :style="{ backgroundColor: $themePalette.grey.v_300 }" | |||
| @@ -42,7 +42,7 @@ | |||
| return this.$computedClass({ | |||
| ':focus': this.$coreOutline, | |||
| ':hover': { | |||
| backgroundColor: this.$themePalette.blue.v_200, | |||
| backgroundColor: this.$themePalette.blue.v_100, | |||
| @@ -341,10 +341,10 @@ | |||
| cancelStyleOverrides() { | |||
| return { | |||
| color: this.$themeTokens.textInverted, | |||
| 'background-color': this.$themePalette.red.v_300, | |||
| 'background-color': this.$themePalette.red.v_600, | |||
There was a problem hiding this comment.
Follow up from: #12742 (comment)
| @@ -3,7 +3,7 @@ | |||
| <div | |||
| v-show="userDevicesUsingIE11" | |||
| class="alert" | |||
| :style="{ backgroundColor: $themePalette.yellow.v_200 }" | |||
| :style="{ backgroundColor: $themePalette.yellow.v_100 }" | |||
There was a problem hiding this comment.
Follow up from here: #12742 (comment)
| @@ -98,7 +98,7 @@ | |||
| return this.$computedClass({ | |||
| ':focus': this.$coreOutline, | |||
| ':hover': { | |||
| backgroundColor: this.$themePalette.blue.v_200, | |||
| backgroundColor: this.$themePalette.blue.v_100, | |||
marcellamaki
merged commit ecbd748
into
learningequality:release-v0.17.x
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves 3 outstanding categories of issues from the KDS upgrade:
References
Please see the first PR and the follow up comments for more details #12742
Reviewer guidance
Manual checks to confirm all is well:
KDateRangecomponent. Are there any regressions? (This is what tipped me off to the second package.json needing updating.)Testing checklist
PR process
Reviewer checklist
yarnandpip)