Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE, FOR QA ONLY] Test KDropdownMenu Keyboard Navigation #12838

Conversation

AlexVelezLl
Copy link
Member

Summary

learningequality/kolibri-design-system#818 Introduces some fixes regarding Keyboard Navigation in KDropdownMenu. This PR introduces these changes in Kolibri for QA to test that this is the expected behaviour.

Reviewer guidance

Look for dropdown menus, and test its behaviour using Keyboard Navigation.

@AlexVelezLl
Copy link
Member Author

@radinamatic could you please take a look and confirm if this is the expected behaviour while keyboard navigating dropdown menus? :)

@radinamatic
Copy link
Member

radinamatic commented Nov 14, 2024

@AlexVelezLl
While testing the keyboard navigation ONLY I did not find any issues, and the dropdown element Options in Device > Channels, and New quiz in Coach > Plan > Quizzes behaved as expected and required.

However, after I tried to confirm the results with the screenreader, my NVDA was not giving the expected output 😕

What we call dropdown is essentially the Menu button pattern from ARIA Authoring Practices Guide (APG). Looking at the page source after I installed the asset on Windows 10, while the proper roles menu and menu-item seem to be applied, the required aria-haspopup property, and the aria-expanded state are not.

Could we fix these property & states issues before merging the PR?

@AlexVelezLl
Copy link
Member Author

Hi @radinamatic, I foresee that including these property & states will need more changes and considerations. And as for now the issue was about fixing the "keyboard navigation", this is a little bit out of scope (and also because this is an existing behaviour rather than a regression introduced in the PR). I will open a follow up issue to make sure we include this too :). Is it okay? 👐

@AlexVelezLl
Copy link
Member Author

Follow up issue for this: learningequality/kolibri-design-system#832

@AlexVelezLl AlexVelezLl deleted the test-kds-kdropdown-focus branch November 19, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants