Fixes filters not displayed on the imported exercises from QA channel #12935
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Thanks @AllanOXDi - I confirm that the filters are working correctly now!
| @@ -21,94 +21,93 @@ | |||
| v-if="windowIsLarge || !currentCategory" | |||
| :class="windowIsLarge ? '' : 'drawer-panel'" | |||
| > | |||
| <div v-if="Object.keys(availableLibraryCategories).length"> | |||
There was a problem hiding this comment.
It seems this check is not being persisted anywhere.
If you look at the original PR where this was moved, it originally was used to wrap the section containing the categories, so that if no categories are in the local library, the section does not get displayed at all.
| :value="value.keywords || ''" | ||
| @change="val => $emit('input', { ...value, keywords: val })" | ||
| /> | ||
| <h2 class="section title"> |
There was a problem hiding this comment.
This <h2> and the next <div> should be wrapped in another div that is conditionalized using v-if="Object.keys(availableLibraryCategories).length".
There was a problem hiding this comment.
Break what? The issue was that the condition was being applied to the entire filters panel previously, so when you were importing resources that had no categories set on them, that was causing the reported issue (that they happened to be exercises was a red herring, I think). Restoring the condition to its correct place just wrapping the categories title and div will restore the previous behaviour.
There was a problem hiding this comment.
No- I was wrapping it wrongly . It's all good now.
AllanOXDi
force-pushed
the
filters-are-not-filtering
branch
from
707c36f to
2d704b1
Compare
| @@ -61,54 +61,55 @@ | |||
| @click="handleCategory(key)" | |||
| /> | |||
| </div> | |||
| </div> | |||
| <div | |||
There was a problem hiding this comment.
Ah, sorry - this div needs to be inside too, as we don't need to show the uncategorized button when there are no categories, because then, by definition, everything is uncategorized!
AllanOXDi
force-pushed
the
filters-are-not-filtering
branch
from
a8411f1 to
c9f4bcd
Compare
Summary
This PR fixes filters not displaying if exercise is imported
Before
390492219-f4848053-14e6-4b67-9b0c-af3668fc2fd9.mp4
After
Screen.Recording.2024-12-11.at.14.26.21.mov
References
closes #12890
Reviewer guidance
Import the exercises from the QA Channel (nakav-mafak) and go to the Library page then the filter panel.