Fix Coach > Quizzes blank page after copying a quiz #12941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Build Artifacts
|
AlexVelezLl
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
At first I thought if it would be better to check how the data is loaded and why these variables were not coming, but during manual QA I realized that this data is loaded at a later stage, so it makes total sense to put these guards for when it is not loaded yet. Thanks Liana!
LianaHarris360
merged commit 025d085
into
learningequality:develop
38 of 39 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After creating a copy of a quiz and clicking the "All quizzes" link, an empty page was displayed with the console error message:
TypeError: Cannot read properties of undefined (reading 'length').The error occurred because assignment.assignments or assignment.learner_ids within getLearnersForAssignment() was not guaranteed to be defined.
The change in this pull request ensures that every assignment object passed into getLearnersForAssignment() has assignments and learner_ids set as empty arrays if there are no items.
CorrectQuizCopyBehavior.mov
References
Closes #12814
Reviewer guidance