Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use 'auto' public paths to resolve resources. #12942

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Don't use 'auto' public paths to resolve resources. #12942

merged 1 commit into from
Dec 13, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Fixes regression in the devserver from using auto public paths in production builds

@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Dec 12, 2024
jredrejo
jredrejo approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's working fine

@github-actions GitHub Actions
Copy link
Contributor

Build Artifacts

Asset type Download link
PEX file kolibri-0.18.0a0.dev0_git.148.g9c5fe4d2.pex
Windows Installer (EXE) kolibri-0.18.0a0.dev0+git.148.g9c5fe4d2-windows-setup-unsigned.exe
Debian Package kolibri_0.18.0a0.dev0+git.148.g9c5fe4d2-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.18.0a0.dev0+git.148.g9c5fe4d2.dmg
Android Package (APK) kolibri-0.18.0a0.dev0+git.148.g9c5fe4d2-0.1.4-debug.apk
Raspberry Pi Image kolibri-pi-image-0.18.0a0.dev0+git.148.g9c5fe4d2.zip
TAR file kolibri-0.18.0a0.dev0+git.148.g9c5fe4d2.tar.gz
WHL file kolibri-0.18.0a0.dev0+git.148.g9c5fe4d2-py2.py3-none-any.whl

@rtibbles rtibbles merged commit f994e5c into learningequality:develop Dec 13, 2024
37 of 38 checks passed
@rtibbles rtibbles deleted the no_auto_kolibri branch December 13, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jredrejo jredrejo jredrejo approved these changes

Assignees
No one assigned
Labels
DEV: backend Python, databases, networking, filesystem...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @jredrejo