Annotate channels with some ordered metadata #12944
Conversation
github-actions
bot
added
the
DEV: backend
Build Artifacts
|
|
|
||
| value_counts = {} | ||
| for value in all_values: | ||
| value_counts[value] = value_counts.get(value, 0) + 1 |
There was a problem hiding this comment.
This is a beautifully concise way to default the value to 0.
|
I thought I had fixed this last remaining flaky content test failure on postgres, but it still happened! Have rerun it. |
|
Looking good to me! I'll give it a bit more of a close review on Monday. If you can do the schema regeneration, I think this should be quickly mergeable. |
…tible with python 3.12, sqlacodegen is trying to import ArgSpec from the inspect module, but this has been removed in Python 3.12
done, but had to modify a bit |
| inspect.ArgSpec = ArgSpec | ||
| inspect.getargspec = getargspec | ||
|
|
||
| # SQLAlchemy 2.0 compatibility patch |
There was a problem hiding this comment.
Why do we need a compatibility patch with SQLAlchemy 2? We explicitly pin to less than 2, and I've not had any issues installing SQLAlchemy 1.4.49 in Python 3.12.
| @@ -45,6 +46,9 @@ class ContentLocalfile(Base): | |||
| class ContentContentnode(Base): | |||
| __tablename__ = "content_contentnode" | |||
| __table_args__ = ( | |||
| CheckConstraint( | |||
There was a problem hiding this comment.
Adding the constraint checks seems to be causing the Python test errors.
Summary
ChannelMetadata, it creates two new fields:included_categoriesincluded_grade_levelsincluded_languagesfrom ManyToManyField to a special type (from a new added library dependency) calledSortedManyToManyFieldChannelMetadataannotationscalculate_included_languagescalculate_ordered_categoriescalculate_ordered_grade_levelsordered_metadata_in_channels, for previously annotated channels (Important note: this has to be skipped in KDP migrations)References
Fixes: #12880
Reviewer guidance