Remove 'pull_request_review' event from the community contributions spreadsheet action #12950
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `pull-request-review` event. When triggered by this event, secrets are not available. This fixes the action failure when pull request reviewed. - Remove unnecessary nuanced event settings. Generally the spreadhseet date should get updated on all associated events.
MisRob
changed the title
This was referenced Dec 16, 2024
|
cc @GarvitSinghal47 just if it'd be interesting for learning, we figured out we cannot keep |
Build Artifacts
|
rtibbles
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_reviewevent. When triggered by this event, secrets are not available. This fixes the action failures when a pull request is reviewed, such as here.References
https://learningequality.slack.com/archives/CB37UM23A/p1733946399034929
Reviewer guidance
I tested here learningequality/test-actions#60