Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non binary content schema #6994

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 5, 2020

Summary

Changes the way we store our SQLAlchemy content schema to python modules, rather than binary files containing the pickles of the Python objects.
Upgrades SQLAlchemy (which we previously couldn't do beyond patch versions because the pickled Python objects depended on the internal APIs not changing).

Reviewer guidance

Does channel import work?

We should hold off merging this until #6873 is merged, so that this can be rebased, and the generation of a new content schema properly tested.

This should hopefully also fix #7004 due to the SQLAlchemy version upgrade.


Contributor Checklist

PR process:

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Testing:

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

Reviewer Checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@codecov
Copy link

codecov bot commented Jun 5, 2020

@indirectlylit
Copy link
Contributor

Is this something we want to target to 0.14?

@rtibbles
Copy link
Member Author

The only reason we would need to is if we wanted to update SQLAlchemy in this release. We can leave this on develop though.

@rtibbles
Copy link
Member Author

OK, looks like for Python 3.8 support we would need to merge this PR, so I think we should prioritize it.

@rtibbles rtibbles changed the base branch from develop to release-v0.14.x June 17, 2020 16:10
@rtibbles rtibbles force-pushed the non_binary_schema branch from cc60c65 to 0e8c292 Compare June 17, 2020 16:21
@rtibbles rtibbles added this to the 0.14.0 milestone Jun 17, 2020
@rtibbles rtibbles marked this pull request as ready for review June 17, 2020 16:22
Copy link
Contributor

@indirectlylit indirectlylit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested import and it works fine

@indirectlylit indirectlylit merged commit 994ef5e into learningequality:release-v0.14.x Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants