-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non binary content schema #6994
Non binary content schema #6994
Conversation
Codecov Report
|
Is this something we want to target to 0.14? |
The only reason we would need to is if we wanted to update SQLAlchemy in this release. We can leave this on develop though. |
OK, looks like for Python 3.8 support we would need to merge this PR, so I think we should prioritize it. |
cc60c65
to
0e8c292
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested import and it works fine
Summary
Changes the way we store our SQLAlchemy content schema to python modules, rather than binary files containing the pickles of the Python objects.
Upgrades SQLAlchemy (which we previously couldn't do beyond patch versions because the pickled Python objects depended on the internal APIs not changing).
Reviewer guidance
Does channel import work?
We should hold off merging this until #6873 is merged, so that this can be rebased, and the generation of a new content schema properly tested.
This should hopefully also fix #7004 due to the SQLAlchemy version upgrade.
Contributor Checklist
PR process:
Testing:
Reviewer Checklist
yarn
andpip
)