Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 8787 #8938

Merged

Conversation

sharifmaryam
Copy link
Contributor

@sharifmaryam sharifmaryam commented Dec 16, 2021

Summary

The icons in the navigation bar tabs were too small and this change overrides the original style to make them bigger.
original:
Screen Shot 2021-12-15 at 11 42 04 PM

now:
Screen Shot 2021-12-15 at 11 40 47 PM

References

Fixes #8787

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the 0.15.1 milestone Dec 16, 2021
@rtibbles
Copy link
Member

Hi @sharifmaryam - thank you for your contribution! This change is targeted to the release-v0.15.x branch. I would suggest copying your existing changes onto a branch made from release-v0.15.x and then force pushing to this branch. That will also delete the commit history that contains your private keys.

@rtibbles
Copy link
Member

Closing - feel free to open a new PR with just the changes.

@rtibbles rtibbles closed this Jan 27, 2022
@rtibbles rtibbles reopened this May 18, 2022
@rtibbles rtibbles added the TODO: needs review Waiting for review label May 18, 2022
@marcellamaki marcellamaki self-requested a review May 18, 2022 20:34
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon fixes look good. Hover state updates will have to be made separately

@marcellamaki marcellamaki merged commit 0618f04 into learningequality:release-v0.15.x May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updates to visual styling of category selection UI
3 participants