Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin django js asset #9163

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Mar 5, 2022

Summary

  • Pins an unpinned dependency that can lead to Django 2+ being required

Reviewer guidance

Do tests still pass and the build complete?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Mar 5, 2022
@rtibbles rtibbles added this to the 0.15.2 milestone Mar 5, 2022
@rtibbles rtibbles changed the base branch from develop to release-v0.15.x March 18, 2022 21:01
@marcellamaki marcellamaki self-requested a review March 28, 2022 14:43
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything building and running fine, no console errors

@marcellamaki marcellamaki merged commit 754e8a1 into learningequality:release-v0.15.x Mar 28, 2022
@rtibbles rtibbles deleted the pin_js_asset branch February 14, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants