Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination issues for facility user page #9422

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented May 10, 2022

Summary

  • Adds an explicit ordering to facility user viewset to prevent warnings
  • Uses pickBy to prevent sending empty query parameters to the backend
  • Drives pagination and filtering via route query parameters.

References

Fixes #9414
Fixes #9413

Reviewer guidance

Confirm that pagination (need more than 30 facility users) works as expected.
Confirm that user search works as expected.
Confirm that filtering by user type works as expected.
Go to another page and then do the above to ensure that it is working.
Check strings work in another language.

Screencast.from.05-10-2022.01_53_07.PM.mp4

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label May 10, 2022
@rtibbles rtibbles requested a review from marcellamaki May 10, 2022 21:00
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that pagination, searching, filtering by type, and translations all work. It also is working on the device permissions user display in the same way.

Will ✅ once javascript tests pass

@marcellamaki marcellamaki merged commit 124bc32 into learningequality:release-v0.15.x May 12, 2022
@rtibbles rtibbles deleted the paging_dr_facility_user branch March 21, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants