Adjust padding for visible focus outline on bottom bar buttons #9478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR redistributes some of the the padding from the outer div of the BottomBar to an inner div so the focus ring is not cut off. It does not change the visual appearance of the spacing (it add up to the same amount for the component).
On the bar on the content renderer, it adds some padding, for the same purpose.
References
Fixes #9464
Fixes #9181
Selection of some pages with the changes applied
Reviewer guidance
I think since I made the changes to the bottom bar itself, most of the issues should be resolved. I cross referenced on multiple pages where it is implemented (see screenshots). However, it is possible there are cases that follow a similar pattern but do not use the
BottomBar
component (such as in the content page, where I added the changes separately).Testing checklist
PR process
Reviewer checklist
yarn
andpip
)