Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable "continue" in quiz creation only once exercises selected #9515

Merged

Conversation

marcellamaki
Copy link
Member

@marcellamaki marcellamaki commented Jun 14, 2022

Summary

This adds a conditional check during quiz creation, and only allows a user to continue once one or more exercises have been selected.

References

Fixes #9472

continue-enabled-on-selection.mp4

Reviewer guidance

  1. Go to create a new quiz
  2. Continue button should be disabled at start
  3. Continue button should be enabled after selecting at least one exercise
  4. unselecting all exercises (individually or for example at the folder level) should re-disable the continue button

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@marcellamaki marcellamaki added the TODO: needs review Waiting for review label Jun 14, 2022
@marcellamaki marcellamaki requested a review from rtibbles June 14, 2022 13:54
@marcellamaki marcellamaki added this to the Planned Patch 4: Coach usability improvements milestone Jun 14, 2022
@marcellamaki marcellamaki requested a review from radinamatic June 14, 2022 14:32
@radinamatic
Copy link
Member

Continue button is now enabled only if at least one exercise has been selected 👍🏽
Tested on Firefox & Chrome on Ubuntu 18 and Windows 10.

continue

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passed, good to go! 💯 :shipit:

@rtibbles rtibbles merged commit 3f65491 into learningequality:release-v0.15.x Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants