Check node being available on filtered queryset to prevent index error. #9539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_tree_queryset
method, it was possible for entirely filtered nodes to not return a 404 from the content node tree endpointReferences
Fixes #9537
Reviewer guidance
Make a request to
/api/content/contentnode_tree/<existing_id>/?parent=<valid_but_nonexistent_id>
and confirm that it does not produce a 500.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)