Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check node being available on filtered queryset to prevent index error. #9539

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 27, 2022

Summary

  • Due to a difference in the queryset filtering for existence checking and the queryset returned from the get_tree_queryset method, it was possible for entirely filtered nodes to not return a 404 from the content node tree endpoint
  • This adds a regression test for this by filtering a specific node and adding a filter parameter that no node can pass (a non-existent but valid parent id)
  • This fixes this issue by filtering the queryset used for the existence check in the same way as the returned queryset

References

Fixes #9537

Reviewer guidance

Make a request to /api/content/contentnode_tree/<existing_id>/?parent=<valid_but_nonexistent_id> and confirm that it does not produce a 500.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jun 27, 2022
@rtibbles rtibbles added this to the Planned Patch 4: Coach usability improvements milestone Jun 27, 2022
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - does fix the issue described from being a 500 error to now be a 404

@marcellamaki marcellamaki merged commit 7b68f64 into learningequality:release-v0.15.x Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants