Improve facility sync status reporting to users

[MisRob]

Summary

Previously, it wasn't possible to find out whether the last sync was successful or if it failed from the facility object itself. We were only able to derive information about failure from task objects while a task was running and that information wasn't persisted on the page reload, resulting in confusing UX.

This PR improves facility sync status reporting to users by persisting information about the success or failure of a facility sync task on the facility object by replacing the last_synced field by last_successful_sync and last_failed_sync fields (that said, we still continue using the failed task information from the task object to display fast update on the sync process to users without the need to re-fetch a facility when the task fails)

Preview of possible states

Never synced	There was no successful sync in the past and the most recent sync failed	There was a successful sync in the past and the most recent sync failed	The most recent sync was successful

References

Resolves #9091

Reviewer guidance

• From "Device -> Facilities" or from "Facility -> Data", sync a facility to another facility or to KDP to test successful sync information
• We currently have no simple mechanism for end-to-end testing of a sync failure - we're planning to do it at least once together with @bjester though

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[jredrejo]

Look good to me, great work. I only have left a couple of comments with the same doubt about a filter, if we can clarify it, it'd be ready from my pov

[MisRob]

Thank you @jredrejo, I've just replied

[bjester]

💯

[MisRob]

We've just tested syncing failure and success with @bjester and looks to be good