Fix show more of top level resources

[marcellamaki]

Summary

Updates the "resource" display logic to be more distinct from topics and search results logic and to have separate management of display.

References

Fixes #9553

Reviewer guidance

Not-logged in and logged-in views:

Jul-08-2022.08-44-48.mp4

QUESTIONS

1. Is this too "simple" of a fix, i.e. should it be more complex to potentially allow for more incremented "view more" display? (such as appending 10 more at a time, rather than just all?)

2. Is this too different from some of the composable setup?

3. Have I accidentally broken anything else?

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[rtibbles]

One other regression to fix here.

All comments resolved. This should be good to merge pending manual QA.

[radinamatic]

Is this too "simple" of a fix, i.e. should it be more complex to potentially allow for more incremented "view more" display? (such as appending 10 more at a time, rather than just all?)

Ideally yes, but might not be a blocker at this point.

Have I accidentally broken anything else?

Browsed this and other channels, nothing jumped out at me 🙂

Signed-in learner (Firefox) and guest (Chrome)

Signed-in admin (Firefox) and guest (Chrome)

[radinamatic]

LGTM! 💯