Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up theme regressions #9558

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jul 11, 2022

Summary

  • Make powered by false by default.
  • Remove unused poweredby from side nav theme.
  • Tweak spec for signin top logo to remove requirement for src.

References

Fixes minor regressions from #8918
Fixes unreported bug where 'powered by Kolibri' is always shown
Fixes #9531

Reviewer guidance

Before:
image

After:
image


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

…av theme.

Tweak spec for signin top logo to remove requirement for src.
@rtibbles rtibbles added this to the Planned Patch 4: Coach usability improvements milestone Jul 11, 2022
@rtibbles rtibbles requested a review from marcellamaki July 11, 2022 22:26
@rtibbles rtibbles added the TODO: needs review Waiting for review label Jul 11, 2022
@rtibbles rtibbles merged commit 3fe5775 into learningequality:release-v0.15.x Jul 11, 2022
@rtibbles rtibbles deleted the powered_by_powered_by_powered_by_kolibri branch July 11, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants