Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues with running morango integration tests on postgres #9571

Merged

Conversation

bjester
Copy link
Member

@bjester bjester commented Jul 20, 2022

Summary

  • Resolves issues with the Morango integration tests when using make test-with-postgres

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester added TODO: needs review Waiting for review TAG: unit tests Add or update tests python Pull requests that update Python code labels Jul 20, 2022
@bjester bjester requested a review from rtibbles July 20, 2022 22:23
@bjester bjester force-pushed the morango-postgres-integ branch from 5fa9e1e to 1395b53 Compare July 20, 2022 22:28
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all make sense - and I am reliably informed that these now run to completion!

@rtibbles rtibbles merged commit dd62726 into learningequality:release-v0.15.x Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code TAG: unit tests Add or update tests TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants