Import fail on error fixes #9591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--fail-on-error` option was only applying to downloaded file transfers, not local file transfers.
The `--fail-on-error` option was only applying when a file was missing from the transfer, not when it was corrupted. In order to have the error bubble up correctly, change the file transfer future function to return an error instead of an integer.
dbnicholson
force-pushed
the
import-fail-on-error-fixes
branch
from
95cc968 to
43089ed
Compare
|
Fixed up the 2.7 error so all the tests pass now. |
rtibbles
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the
importcontent--fail-on-erroroption handle more error cases.References
Previously this was implemented in #9259 to address #9258. I opened #9590 to track the fixes here.
Reviewer guidance
There are test cases added and #9590 has a procedure to test with local kolibri instances.
Testing checklist
If there are any front-end changes, before/after screenshots are includedCritical user journeys are covered by Gherkin storiesPR process
Reviewer checklist
yarnandpip)