-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PDF completion issues #9776
Fix PDF completion issues #9776
Conversation
@rtibbles I have started testing this one and so far the only issue I've found is that the completion modal gets displayed immediately on opening a 1 page pdf file, thus completely preventing me to even see what the pdf is about. 2022-10-17_18-10-02.mp4 |
I think properly addressing this would require solving this issue: #9348. I can probably fudge it for now, but just implementing a solution for the above might be easier. |
@rtibbles no additional regressions observed during today's round of testing in the rest of the supported browsers and the Android app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passes, experience will be further improved by working on #9348 afterwards 💯
OK, have put the above issue into the current patch so that we can try to get this resolved within the same patch. Merging! |
Summary
RecycleList
update
event, and instead just debounces the PDF page rendering which is the expensive call.scrollTop
is still on the second to last page, but the browser cannot scroll any further. Does this by checking to see if we are on the second to last page, but the browser viewport cannot scroll any further. In this case, we mark both the second to last and last pages as viewed.progress_delta
being sent to the backend could inadvertently be summed to a value greater than 1.References
Fixes #8868
Reviewer guidance
Continually scroll without stopping from the beginning of a PDF until the end. See that it properly marks as complete.
Zoom out slightly so that more than one page of a PDF is rendered at once. Continually scroll without stopping until the end of the PDF. See that as long as no more than 2 pages are visible on the screen at once, it properly marks as complete.
(This is an edge case where if someone were reading through the PDF in a way that allowed for three or more pages to be visible at once, completion would not be marked - someone would probably need a monitor with an aspect ratio with the height about three times the width at least for this to happen, so I think it's not something to be concerned about).
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)