Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync resources - Some fields in 'Edit details' don't get updated after attempted sync #3111

Closed
pcenov opened this issue Apr 26, 2021 · 9 comments
Assignees
Labels
P1 - important Priority: High impact on UX

Comments

@pcenov
Copy link
Member

pcenov commented Apr 26, 2021

Should be done in combination with: #4090

Observed behavior

A number of fields don’t get updated after having selected all available ‘sync’ options:
Language, Visible to, Provider, Aggregator, License description

Expected behavior

All fields should be updated as I've selected the option to update all file information.

Steps to reproduce the issue

  1. Create a channel A and channel B.
  2. Upload a file in channel A and then import the same file in channel B.
  3. Edit all details of the file in channel A.
  4. Go to channel B and select the option to sync all resources (select all checkboxes in the modal window).
  5. Compare the details for both files.

Additional information

2021-04-26_13-39-03

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Jun 8, 2023

@bjester in case this issue was missed by everyone, as it has been left unassigned, just wanted to mention that it's still valid in the latest release

@bjester bjester added the P1 - important Priority: High impact on UX label Jun 8, 2023
@bjester bjester added this to the Studio: upcoming patches milestone Jun 8, 2023
@bjester
Copy link
Member

bjester commented Jun 20, 2023

Related to this, we should actually prevent editing of the 'Source' fields, since a user shouldn't be able to change the licensing for a copied/imported resource.

We may still need to update the sync to write over these fields, to fix existing copied/imported issues, since they would become no longer editable with the referenced issue fix.

@akolson
Copy link
Member

akolson commented Jun 20, 2023

Hi @bjester! I am picking this up!

@akolson akolson self-assigned this Jun 20, 2023
@bjester
Copy link
Member

bjester commented Jun 20, 2023

Thanks @akolson! I also assigned #4090 since it makes sense to do them together

@akolson
Copy link
Member

akolson commented Jul 5, 2023

Hi @bjester! Just confirming here before I open a pr that we should prevent edits for all "Source" fields when a resource has been copied/imported. A user should be able to edit the "Source" fields in other circumstances, is this correct?

@bjester
Copy link
Member

bjester commented Jul 5, 2023

@akolson Yes that sounds correct to me. Will you make these fields disabled?

@akolson
Copy link
Member

akolson commented Jul 5, 2023

@bjester disabled vs readonly?

@bjester
Copy link
Member

bjester commented Jul 5, 2023

@akolson Good thinking. readonly is more appropriate 👍

@bjester
Copy link
Member

bjester commented Apr 24, 2024

Closing because of #4189 and opened new remaining issue #4190

@bjester bjester closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX
Projects
None yet
Development

No branches or pull requests

3 participants