Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel details - The channel info is not getting updated correctly #4123

Open
pcenov opened this issue Jun 9, 2023 · 6 comments
Open

Channel details - The channel info is not getting updated correctly #4123

pcenov opened this issue Jun 9, 2023 · 6 comments

Comments

@pcenov
Copy link
Member

pcenov commented Jun 9, 2023

Observed behavior

When I remove some resources from my channel and publish it the resources' metadata and thumbnail remain visible on the channel info page. At the moment the info page is not getting updated even when I add new resources and publish the channel but at some point that seem to be working correctly.

Expected behavior

If I publish a channel after having removed or added resources the channel info page should be updated accordingly.

Steps to reproduce the issue

  1. Open a channel
  2. Select a resource and click the delete button
  3. Publish the channel and go to the channel's info page

Additional information

2023-06-09_18-10-14.mp4

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Jun 9, 2023

@radinamatic @bjester

@radinamatic
Copy link
Member

Not sure if some of this will be affected by #4113

@bjester
Copy link
Member

bjester commented Jun 9, 2023

There's some caching on the endpoint which returns this information. It is likely enqueuing a task to update it when it's loaded post-publish, but it returns the old cached data until that task is completed

@bjester bjester removed this from the Kolibri 0.16 Release: Studio Support milestone Jun 9, 2023
@bjester
Copy link
Member

bjester commented Jun 20, 2023

We should update the publishing process to write theses details to a cache. The current approach relies on requests to the channel details API endpoint, to queue a task in order to update the cached details. This means that those details could reflect the current state of the channel and not the last published version's state. So proactively caching this information during publishing and retaining that cache until the next publish makes a lot of sense.

@bjester bjester self-assigned this Jul 5, 2023
@rtibbles rtibbles added this to the Studio: upcoming patches milestone Aug 15, 2023
@bjester
Copy link
Member

bjester commented Aug 29, 2023

This issue needs to be re-written to clearly outline the needed change, as the issue is a consequence of the current implementation.

@bjester bjester removed their assignment Aug 29, 2023
@vkWeb

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants