-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node details query to use CTE and more robust tests #4824
Update node details query to use CTE and more robust tests #4824
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: contentcuration/contentcuration/models.py
📄 File: contentcuration/contentcuration/views/nodes.py (Click to Expand)
Did you find this useful? React with a 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test cases look like good coverage and inspire confidence (and all pass)! No regressions spotted in manual testing.
@@ -114,14 +114,26 @@ | |||
}, | |||
mounted() { | |||
this.load(); | |||
this.$analytics.trackAction('channel_details', 'View', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -493,6 +493,14 @@ | |||
return this.categories.join(', '); | |||
}, | |||
}, | |||
mounted() { | |||
if (!this.isChannel) { | |||
// Track node details view when not a channel-- is this happening? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think not!
No regressions observed while viewing the channel details. |
Summary
Description of the change(s) you made
Manual verification steps performed
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Fixes #4795
Comments
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)