Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tree edit styling #1179

Merged
merged 8 commits into from
Jan 17, 2019
Merged

Fixed tree edit styling #1179

merged 8 commits into from
Jan 17, 2019

Conversation

jayoshih
Copy link
Contributor

@jayoshih jayoshih commented Jan 16, 2019 •
edited
Loading

Description

Fixed styling on topic tree, including issue where clicking the topic options opened the topic, not the options

Issue Addressed (if applicable)

Addresses #1118

Before/After Screenshots (if applicable)

Flex not rendering on preview mode
image

Horizontal scrollbar was not visible in RTL
image

Steps to Test

  • Click the options menu and make sure it opens the popover
  • Switch to RTL and see if horizontal scrollbar appears
  • Open preview mode and check that content lists are the same height

Checklist

  • Is the code clean and well-commented?
  • Have the changes been added to the CHANGELOG?
  • Are all UI components LTR and RTL compliant (if applicable)?

@jayoshih jayoshih requested a review from micahscopes January 17, 2019 02:39
micahscopes
micahscopes approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@micahscopes micahscopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jayoshih jayoshih merged commit 379d44d into learningequality:develop Jan 17, 2019
@jayoshih jayoshih deleted the topic-fix branch May 28, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahscopes micahscopes micahscopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayoshih @micahscopes