-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to retry copy failures #4176
Conversation
@bjester I've fixed the merge conflict, ready for review & merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions, but only two main areas to focus on for requested for changes:
- Seems undoing a copy isn't working-- there was an issue that was fixed in hotfixes but since you merged that in, I expect it to still work
- Some CSS issues-- the copy failure text and CTA is causing overflow for smaller widths, and the CTA and message are different font sizes. Additionally, it could use better vertical alignment between the icon, text and CTA
contentcuration/contentcuration/frontend/channelEdit/views/CurrentTopicView.vue
Show resolved
Hide resolved
I tried on hotfixes and unstable, I am not able to undo copying. I think we need to fix it, let's do it with this PR itself @bjester?
Let me try sir fixing those! |
I checked why undoing copy isn't working. Here's my take sir: the record is being successfully deleted only at the indexed db level, Vuex isn't reflecting it, backend isn't affected as well. Record still exists on the backend. |
You're right-- the UNDO of a copy seems to have regressed again |
@bjester I've fixed the font-size. Fixing font-size seemed to have solved the vertical-alignment problem I feel. So, this is ready for final review and merge sir 🎉 Let me know if it needs anything! |
While manual testing this, I have observed an edge case. Putting this as draft until I solve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vkWeb There's still some misalignment with the text. I committed one change to your PR, on code that was pre-existing. Let me know if you have questions about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a new issue for the misalignment of the CTA as discussed. Merging this!
Summary
This PR brings in the capability to retry failed copies and detection of failing copies.
Manual verification steps performed
To generate copy error state on the frontend, I raised an exception from the backend copy function. These are the checks I've performed:-
changesForSyncing
table are detected.Screenshots (if applicable)
The below screenshot is the current design, it's matching with the expected design. (thanks to sir @bjester for helping me out fix the design).
The below is the UI design that is expected.
Does this introduce any tech-debt items?
Possible tech-debts:-
retry
action can be refactored to make it responsive and robust.Reviewer guidance
Does manual verification steps checks out green?
References
Closes #2850.
Closes #3914.
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)