Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent errors when creating already existing tag through model entries. #4232

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Adds ignore_conflicts=True when bulk creating Tag through objects to prevent errors from duplicated entries which break copying, but are not an issue.
  • Adds a TODO for future cleanup of Tag creation to leverage the same

Manual verification steps performed

I couldn't reproduce this so went for the minimal fix - as long as the Python tests pass, I think this is adequately covered by automated tests.

References

Fixes #4221


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added this to the Studio: upcoming patches milestone Jul 19, 2023
@rtibbles rtibbles requested a review from bjester July 19, 2023 20:27
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed up on Slack about missing tags despite the error, but this looks good nevertheless

# rtibbles: For reasons I have not been able to discern, under certain circumstances
# these mappings can already exist in the database. This is a workaround to prevent
# this from breaking copying.
self.model.tags.through.objects.bulk_create(mappings_to_create, ignore_conflicts=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank goodness for ignore_conflicts!

@rtibbles
Copy link
Member Author

Have done a bit more investigation here, and I now think I know why this has happened and can write a regression test for it, so will push another commit with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants