Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance tests and add special handling for mptt fields. #4251

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 9, 2023

Summary

Description of the change(s) you made

Fixes issue with import metadata public endpoint where mptt fields would be excluded.
Caused by the lack of mptt fields on abstract model's meta

Manual verification steps performed

  1. Updated tests
  2. Made tests print out all the fields being returned
  3. Confirmed the mptt fields were now being properly returned!

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit 0816bb2 into learningequality:hotfixes Aug 10, 2023
@bjester bjester mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants