Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppNexus - The API Layer for contentcuration #4282

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

akash5100
Copy link
Contributor

@akash5100 akash5100 commented Sep 13, 2023

Summary

Description of the change(s) you made

This PR sets up the foundational file structure and architecture for the contentcuration app's flexible API layer in Studio, following a modular pattern that separates adapters, backends, and core components, aligning with Studio's codebase conventions.


Reviewer guidance

How can a reviewer test these changes?

Not applicable for now

References

Closes #4275

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akash5100 akash5100 requested a review from bjester September 18, 2023 19:37
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks correct to me and comments suggested by Blaine are implemented. @bjester any other comments? Also, checking to confirm that the merge should be into unstable?

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous comment wasn't fully resolved. Left more feedback, after which I think we can merge. Let me know if you have questions

contentcuration/contentcuration/utils/appnexus/base.py Outdated Show resolved Hide resolved
contentcuration/contentcuration/utils/appnexus/base.py Outdated Show resolved Hide resolved
@akolson akolson merged commit ab00a58 into learningequality:unstable Sep 22, 2023
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development of Flexible API Layer
3 participants