-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppNexus - The API Layer for contentcuration #4282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks correct to me and comments suggested by Blaine are implemented. @bjester any other comments? Also, checking to confirm that the merge should be into unstable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous comment wasn't fully resolved. Left more feedback, after which I think we can merge. Let me know if you have questions
Summary
Description of the change(s) you made
This PR sets up the foundational file structure and architecture for the contentcuration app's flexible API layer in Studio, following a modular pattern that separates adapters, backends, and core components, aligning with Studio's codebase conventions.
Reviewer guidance
How can a reviewer test these changes?
Not applicable for now
References
Closes #4275
Comments
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)