Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node availability when propagating import copy #4377

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

vkWeb
Copy link
Member

@vkWeb vkWeb commented Jan 4, 2024

Summary

Here I've fixed the undefined original_source_node_id TypeError. After importing a contentnode, when this change was getting relayed to the other channel editor, we were getting that error on the other channel editor's end because the contentnode which has to be imported was not present in the Indexed DB.

Investigation credits to our ironman @bjester. Code credits to me.

Manual verification steps performed

  1. Login as a@a.com (admin).
  2. Create a new channel with any resource, for e.g. one PDF file. Publish it and make it public.
  3. Create another channel.
  4. Invite user@b.com to this new channel with edit rights.
  5. On another browser window login as user@b.com, accept the invitation and open the invited channel.
  6. From admin browser, import a content from the public channel.
  7. Check the user@b.com browser, the imported content should be visible.
  8. There must be no error on the developer console.

Reviewer guidance

Manual verification steps should be enough.

References

Closes #4332.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vkWeb vkWeb requested a review from bjester January 4, 2024 11:07
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right change to me. Since this occurs in handling remote changes, this is unlikely to break anything, but we will test this during pre-release QA.

@bjester bjester merged commit f02a304 into learningequality:unstable Jan 18, 2024
11 checks passed
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'original_source_node_id')
2 participants