-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed components to KComponents #4398
Changed components to KComponents #4398
Conversation
The command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look correct to me and manual QA checks out. The reported linting build issue looks to be an issue with the current version of kolibri-tools
being used in studio. Updating it should resolve the issue. cc @ozer550
I agree! Should be ready to go in, Just one suggestion @BabyElias, you could also use the pre-commit hooks for liniting which could help regarding linting issues before each commit. To install pre-commit hooks you could run |
Ohkay @ozer550! Will keep this handy from next PRs. |
Hey! |
Hi @BabyElias - it looks like you just need to commit the formatting change in TreeViewBase after running linting. What looks like an error in the command is actually just a log message, the reason it is exiting with error 1 is because of the formatting change. |
Thank you @rtibbles! Doing this just perfectly solved the problem I had been facing for long now :) |
This should be good for a merge. Thanks @BabyElias! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Summary
Updated IconButton to use KComponents (KIcon & KIconButton) instead. This is the part of a series of changes, to be made under Issue #219 in Kolibri Design System.
Description of the change(s) you made
learningequality/kolibri-design-system#219
Screenshots (if applicable)
The icons that have been changed
Contributor's Checklist
Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)