Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed components to KComponents #4398

Merged

Conversation

BabyElias
Copy link
Contributor

Summary

Updated IconButton to use KComponents (KIcon & KIconButton) instead. This is the part of a series of changes, to be made under Issue #219 in Kolibri Design System.

Description of the change(s) you made

learningequality/kolibri-design-system#219

Screenshots (if applicable)

change
Screenshot-12

The icons that have been changed

Contributor's Checklist

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@BabyElias
Copy link
Contributor Author

The command yarn run lint-frontend:format is exiting with an error I am unable to figure anything about.
Any help to fix this linting error would be highly appreciated.
Thanks!

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct to me and manual QA checks out. The reported linting build issue looks to be an issue with the current version of kolibri-tools being used in studio. Updating it should resolve the issue. cc @ozer550

@ozer550
Copy link
Member

ozer550 commented Jan 15, 2024

Changes look correct to me and manual QA checks out. The reported linting build issue looks to be an issue with the current version of kolibri-tools being used in studio. Updating it should resolve the issue. cc @ozer550

I agree! Should be ready to go in, Just one suggestion @BabyElias, you could also use the pre-commit hooks for liniting which could help regarding linting issues before each commit. To install pre-commit hooks you could run pre-commit install in your studio directory with the virtual environment on and this should do the magic.

@BabyElias
Copy link
Contributor Author

Changes look correct to me and manual QA checks out. The reported linting build issue looks to be an issue with the current version of kolibri-tools being used in studio. Updating it should resolve the issue. cc @ozer550

I agree! Should be ready to go in, Just one suggestion @BabyElias, you could also use the pre-commit hooks for liniting which could help regarding linting issues before each commit. To install pre-commit hooks you could run pre-commit install in your studio directory with the virtual environment on and this should do the magic.

Ohkay @ozer550! Will keep this handy from next PRs.

@BabyElias
Copy link
Contributor Author

Hey!
Are any changes needed on this PR?

@rtibbles
Copy link
Member

Hi @BabyElias - it looks like you just need to commit the formatting change in TreeViewBase after running linting. What looks like an error in the command is actually just a log message, the reason it is exiting with error 1 is because of the formatting change.

@BabyElias
Copy link
Contributor Author

Thank you @rtibbles! Doing this just perfectly solved the problem I had been facing for long now :)

@akolson
Copy link
Member

akolson commented Jan 22, 2024

This should be good for a merge. Thanks @BabyElias!

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@akolson akolson merged commit fb7ccbb into learningequality:unstable Jan 22, 2024
11 checks passed
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants