Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade KDS to v3 in hotfixes branch #4454

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

bjester
Copy link
Member

@bjester bjester commented Feb 23, 2024

Summary

Description of the change(s) you made

  • Upgrade to v3 of KDS in hotfixes branch

Manual verification steps performed

None - see #4412

Screenshots (if applicable)

Does this introduce any tech-debt items?

Yes the merge conflicts with unstable will need to be resolved


Reviewer guidance

How can a reviewer test these changes?

see #4412

Are there any risky areas that deserve extra testing?

see #4412

References

#4412

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

MisRob and others added 3 commits February 23, 2024 08:30
Fixes "Error: Can't resolve 'kolibri-design-system/lib/utils/i18n'"
caused by removal of this file in KDS v2.0.0 by copying the removed
file content directly to Studio.
Remove deprecated `value` prop in favor of the new
`buttonValue` prop that's supposed to replace it
in `KRadioButton`.
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies that after my review last week, I didn't actually "submit"! The code changes that you brought in from the kds upgrade look good here, and everything seems to be running fine locally. Thank you @bjester for all of the hard work with this upgrade!

@marcellamaki marcellamaki merged commit 6cf31f8 into learningequality:hotfixes Mar 5, 2024
9 checks passed
@akolson akolson mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants