Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade KDS from v3.0.1 to v3.2.0 #4528

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Apr 20, 2024

Summary

Upgrades KDS from v3.0.1 to v3.2.0

No updates are needed. Related release notes:

Also fixes #4502 (comment)

Manual verification steps performed

  • Previewed release notes
  • Briefly run Studio

Reviewer guidance

How can a reviewer test these changes?

  • You can see the release notes
  • I think it should be safe to merge as it's just patch or minor releases

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Sorry, something went wrong.

@MisRob MisRob mentioned this pull request Apr 20, 2024
24 tasks
@MisRob MisRob requested a review from bjester April 20, 2024 15:51
@MisRob MisRob requested a review from akolson April 20, 2024 15:51
@MisRob MisRob force-pushed the upgrade-kds-to-3.2.0 branch from 213f632 to 9e9b8b5 Compare April 20, 2024 15:51
@bjester bjester merged commit ec593f8 into learningequality:unstable Apr 22, 2024
13 checks passed
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants