-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalization of rebranded logos #4539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think those templates might be unused! |
Hi @rtibbles, here's what I am currently observing at hotfixes when I create a new channel without a logo: 2024-04-30_13-00-09.mp4Is this channel logo supposed to be changed to a kolibri logo with rectangular background? |
@pcenov What you're seeing is correct-- that shouldn't be the kolibri logo. The Kolibri placeholder logo shows up in the clipboard. I believe it might also show up in the public-facing channel details, but I'd have to double check |
Thanks @bjester - in that case I can confirm that the new logo is displayed in the clipboard: 2024-04-30_17-18-52.mp4I've never really thought about it before but why are we showing that logo for all the channels in the clipboard? Shouldn't it be applied only for the channels without a logo? |
@pcenov hmm, yes it should only show in the clipboard if the channel doesn't have a logo/thumbnail. I don't know why that would change. The tabbed colors on the clipboard are supposed to be based off the colors in the thumbnail (excluding those without). So it seems like something has regressed, because the pink from Career Girls should align with the logo/thumbnail. |
@pcenov Yeah I'm seeing a discrepancy. If I copy to clipboard through the 'Import from channels' modal, it seems to show up. If I copy to clipboard through alternative ways, it doesn't. Can you confirm? perhaps this is existing |
Added #4545 |
Summary
Description of the change(s) you made
kolibri_login.png
tokolibri-logo.png
Manual verification steps performed
I seem to be having issues with my local devserver connecting to my postgres instance, so I wasn't able to manually test - a double check would be very much appreciated!
Screenshots (if applicable)
See above :/
Reviewer guidance
How can a reviewer test these changes?
Check a newly created channel without a channel thumbnail set.
Make sure the favicon looks OK!
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)