Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalization of rebranded logos #4539

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Updates all Kolibri logo derived image files to use the new logo:
    • kolibri-logo.png is updated to be the standard kolibri logo with blob
    • kolibri_placeholder.png is updated to be a kolibri logo with rectangular background - this has then been manually edited using GIMP to widen to a 16:9 aspect ratio
    • kolibri-logo.ico is updated to be a kolibri logo with rectangular background
  • Updates all references to kolibri_login.png to kolibri-logo.png

Manual verification steps performed

I seem to be having issues with my local devserver connecting to my postgres instance, so I wasn't able to manually test - a double check would be very much appreciated!

Screenshots (if applicable)

See above :/

Reviewer guidance

How can a reviewer test these changes?

Check a newly created channel without a channel thumbnail set.
Make sure the favicon looks OK!


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested review from bjester and akolson April 26, 2024 21:31
@rtibbles rtibbles added this to the Studio: rebranding patch milestone Apr 26, 2024
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the favicon, the contrast doesn't seem as good. It's harder to tell what it is, I think because of the domination of the yellow. Could just be my eyes. The screenshots don't really do it justice because they're 2x the actual visual size

Screenshot from 2024-04-29 07-32-12
Screenshot from 2024-04-29 07-31-50

@bjester
Copy link
Member

bjester commented Apr 29, 2024

I also think those templates might be unused!

@bjester bjester merged commit fb5a3d1 into learningequality:hotfixes Apr 29, 2024
9 checks passed
@akolson akolson mentioned this pull request Apr 29, 2024
@pcenov
Copy link
Member

pcenov commented Apr 30, 2024

Hi @rtibbles, here's what I am currently observing at hotfixes when I create a new channel without a logo:

2024-04-30_13-00-09.mp4

Is this channel logo supposed to be changed to a kolibri logo with rectangular background?

@bjester
Copy link
Member

bjester commented Apr 30, 2024

@pcenov What you're seeing is correct-- that shouldn't be the kolibri logo. The Kolibri placeholder logo shows up in the clipboard. I believe it might also show up in the public-facing channel details, but I'd have to double check

@pcenov
Copy link
Member

pcenov commented Apr 30, 2024

Thanks @bjester - in that case I can confirm that the new logo is displayed in the clipboard:

2024-04-30_17-18-52.mp4

I've never really thought about it before but why are we showing that logo for all the channels in the clipboard? Shouldn't it be applied only for the channels without a logo?

@bjester
Copy link
Member

bjester commented Apr 30, 2024

@pcenov hmm, yes it should only show in the clipboard if the channel doesn't have a logo/thumbnail. I don't know why that would change. The tabbed colors on the clipboard are supposed to be based off the colors in the thumbnail (excluding those without). So it seems like something has regressed, because the pink from Career Girls should align with the logo/thumbnail.

@bjester
Copy link
Member

bjester commented Apr 30, 2024

@pcenov Yeah I'm seeing a discrepancy. If I copy to clipboard through the 'Import from channels' modal, it seems to show up. If I copy to clipboard through alternative ways, it doesn't. Can you confirm? perhaps this is existing
image

@bjester
Copy link
Member

bjester commented May 1, 2024

Added #4545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants