-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MVP modal for applying inheritable metadata #4664
Add MVP modal for applying inheritable metadata #4664
Conversation
8e6a56a
to
94937a6
Compare
Allow passing in non camelcased labels.
Update component API. Implement updates in edit modal.
…ies using vuex state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marcellamaki @rtibbles! The implementation generally looks correct to me. The code makes sense and Manual QA seems to checkout. The code could be improved further in some areas where it is quite nested and tending to get a little confusing, but for an MVP, this should be sufficient and don't see this as a blocker!
thanks so much for the speedy review @akolson. Good point with the functions -- there are definitely some places including where the metadata labels are getting parsed that one can get a bit lost in. I'll open a follow up issue for some cleanup or other things to make the code clearer. I'll link it here and if you have specific suggestions (areas you had to read multiple times to understand, places where comments would help, suggestions for which functions to break up), please go ahead and either edit the issue directly or add a comment! |
Not sure why, but I got a bit of an inconsistent behavior at point 3. and 4. listed above, but only for the second folder I created: for resources moved from other folders I was not prompted with the modal to apply folder details, but I was when I moved resources from the clipboard into this second folder. Folders test1 and test2 have been created with the usual identical steps, just with different categories, levels, and requirements. I was also not getting the modal to apply details to resources moved into the test4 folder for the scenario 8. above... 🤔 Could these inconsistencies have something to do with the fact that the current implementation for the bulk editing has the |
This PR adds additional functionality so that when a user uploads, imports, or moves a resource to a folder (moving can be with the "move" button, drag and drop, or copying via the clipboard) that has "bulk edit-able" metadata, they are prompted to select any options they would like that resource to inherit.
Steps for manual QA: