Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where currentChannel was undefined after channel deletion #4866

Closed

Conversation

Dhanushcdivakar
Copy link

This PR addresses the issue where the currentChannel variable was undefined in the CurrentTopicView.vue component when a channel was deleted in another tab while the page was open. It adds a watch on currentChannel to detect when it becomes undefined and implements fallback logic to prevent errors when accessing properties of currentChannel. Manual verification steps included testing the deletion of a channel in one tab while the page remained open in another, ensuring that no errors occurred and the UI reflected the channel's removal properly. This change stabilizes the component by handling the deletion scenario gracefully.

@MisRob MisRob requested a review from nucleogenesis January 15, 2025 16:53
@MisRob MisRob removed the request for review from nucleogenesis January 15, 2025 16:54
@MisRob
Copy link
Member

MisRob commented Jan 15, 2025

Hi @Dhanushcdivakar,

the PR description doesn't reflect the code changes, for example

It adds a watch on currentChannel to detect when it becomes undefined and implements fallback logic to prevent errors when accessing properties of currentChannel.

Also, I'd ask you to fill the PR template sections as suggested.

@MisRob MisRob closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants